CodeSOD: The Bad Batch

Ashton works for a large bank, on an application that handles millions of dollars of transactions. The previous developer left this behind, which has everyone on the team scratching their heads.

if (BatchProcessor.ProcessBatch()) { } else { }

It seems obvious that the if is unnecessary. But it's there. It was clearly put there for a reason. No one wants to remove it, for fear of breaking some invisible connection in the code. Maybe it's just superstition, and I'm sure it will eventually be removed or perhaps replaced with actual error handling, but for the moment, everyone is just hesitant to touch something that works and they don't understand.

[Advertisement] BuildMaster allows you to create a self-service release management platform that allows different teams to manage their applications. Explore how!

This post originally appeared on The Daily WTF.

Leave a Reply

Your email address will not be published. Required fields are marked *