CodeSOD: Dented

At many a workplace, I've had the fortune to step into the company around when they were starting to get serious about standards, code quality, and generally pivoting into a mature development organization.

When it comes to coding standards, everyone has strong opinions, though frankly consistency matters more than the standard itself. For example, with indenting, it doesn't really matter if you're doing Allman or something more K&R. Though we can all agree that anyone using [Whitesmiths] style has been hurt, and hurt deeply.

Which brings us to today's code, from Christopher, which introduces an entirely new style: inverted.

        void push(Node** headRef, int data){
Node* newNode = (Node*) malloc(sizeof(newNode));
newNode->data = data;
*headRef = newNode;
        Node* pushtop(){
Node* head = NULL;
int i;
for(i = 1; i<=3; i++){
return head;

Neither I nor Christopher is entirely sure what happened here, but it does meet my main standard: it was used consistently. Method bodies got de-indented. Was it an autoformatter gone wrong? Just badly copypasted code everywhere? Or did someone do this on purpose?

Regardless, it gives us something that's even more wrong than Pico indenting.

[Advertisement] Continuously monitor your servers for configuration changes, and report when there's configuration drift. Get started with Otter today!

This post originally appeared on The Daily WTF.

Leave a Reply

Your email address will not be published. Required fields are marked *